awsomesud347 commented on PR #12130: URL: https://github.com/apache/seatunnel/pull/12130#issuecomment-5640029839
@SEZ9 That comment is complete on GitHub, so your view may be truncating long comments. The short version, on `2dd45e26f`: - F2 is parity, not a change. `checkPageInRange` at `PageBaseServlet.java:148` uses `start > total`, the same as the legacy check. - F3 is in `docs/en/engines/zeta/rest-api-v2.md:786-795` and its zh counterpart, plus `incompatible-changes.md` in both languages. - F4 is shared rather than deferred. `writeJsonWithPagination` at `:48` now calls `pageParams`, `checkPageInRange` and `writeJsonPage`, so `RunningJobsServlet` uses the same path. - F6 is at `JobInfoService.java:135-146`. - F7 is a new `FinishedJobsServletTest` with nine servlet tests. - F8 is tracked in the PR description for a later PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
