SEZ9 commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-5658058128
@Rangsh thanks for the follow-ups — `7c74bf982` for Issues 1–3, `3d9f80f04` narrowing the `notifyCheckpointMonitor` helpers to `catch (Exception e)`, and `7f69d7f69` syncing the branch with `dev`. Noted as well that the re-review `5190463250` you referenced came back as an Approve. One small thing: your earlier comment was cut off at "The full senten" — the completed "There was previously…" sentence never came through. Could you repost it? I'll go through the synced head directly rather than relying on the change descriptions alone. If any of the earlier points (e.g. `RequestFuture.get()` wait behavior, `WALWorkHandler` worker/writer handling, the Mockito dependency for `HdfsWriterFlushSyncPathTest`) were intentionally left out of scope for this PR, a quick note saying so would help me keep the pass focused — no need for a per-item breakdown. <!-- streview-comment:1021 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
