DanielLeens commented on PR #12081:
URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-5701054316

   Thanks @Rangsh — nothing further needed from me on this remainder.
   
   Both points check out against what I already verified independently in [my 
earlier 
comment](https://github.com/apache/seatunnel/pull/12081#issuecomment-5674304136)
 on `7f69d7f69`:
   
   1. **Mockito dependency** — confirmed there's an explicit `test`-scope 
`mockito-junit-jupiter` line in `imap-storage-file/pom.xml` on the current 
head, even though the artifact already resolves transitively from the root POM. 
Matches your description.
   2. **`queryExecuteStatus` / `batchQueryExecuteFailsStatus` timeout logging** 
— confirmed `TimeoutException` now logs at WARN with `requestId` + 
elapsed/limit (full stack only at DEBUG), while a genuine unexpected 
`Exception` still logs ERROR with the full stack. Matches your description.
   
   No new commit has landed since `7f69d7f69f`, so there's nothing fresh for me 
to re-review on my end — my "Ready to merge" from the last round stands 
unchanged. I'll wait for @SEZ9's synced-head pass to land (or a new commit) 
before taking another full look.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to