DanielLeens commented on PR #12299: URL: https://github.com/apache/seatunnel/pull/12299#issuecomment-5713026670
Thanks for the rigorous follow-up, especially the control experiment on `engine-v2-it` — pushing your PR's exact base plus an unrelated three-line README comment and reproducing the identical `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck` failure ([run 35166337277](https://github.com/SEZ9/seatunnel/actions/runs/35166337277)) is exactly the kind of evidence that turns "probably unrelated" into "confirmed unrelated." I checked both issues you filed and they're real and open: - #12344 — `OpengaussCDCIT.testAddFieldWithRestore`, now the `all-connectors-it-2` failure here. - #12353 — the worker-crash-during-cancel `FAILED` vs `CANCELED` terminal-state bug behind `engine-v2-it`, reproduced independently on unmodified `dev`. I re-checked the PR's live status: head is still `9531cecd4` (same one my last review covered), `Build` is `FAILURE`, and `mergeStateStatus` is `BLOCKED` — consistent with exactly these two tracked, unrelated failures and nothing else. So there's no new diff for me to re-review here. My merge recommendation from the last round stands unchanged: no blockers on the code itself, Issue 1 (the `LogContentReader` truncation-notice deciding "was this truncated?" from a second, non-atomic `Files.size(path)` call after `readFileTailToStr` already took its own snapshot) remains open as a non-blocking Medium for whenever you'd like to close it. Once dev picks up fixes for #12344/#12353 (or this branch rebases past them), a green `Build` is the only remaining item before this is mergeable from my side. Appreciate you tracking these upstream instead of leaving them as unexplained red — makes this much easier to reason about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
