SEZ9 commented on PR #12299: URL: https://github.com/apache/seatunnel/pull/12299#issuecomment-5825814710
@DanielLeens, the six follow-up items from your review are addressed in `50567aa788b0`, rebased onto `dev` at `deb16a3c3152`. 1. `FileUtils.FileTail` carries retained bytes, the file-size snapshot and the truncation decision from the same open channel. `LogContentReader` no longer performs a second `Files.size(path)`. The positive-limit path also stays bounded if a file that initially fits grows during the read. Tests verify that growth and removal after reading do not change the response or cause a later path lookup. 2. Extended the existing `RestApiIT`: a 1 MB configuration is exercised through v1 and v2 `/log/<file>` and `/logs/<file>` requests, checking the notice, bounded suffix and valid UTF-8. The existing YAML/config test also verifies parsed byte values, the 64 MB default, non-positive opt-outs and large MB values without integer overflow. 3. Fixed both v1-to-v2 links with a shared explicit anchor, and clarified the nested YAML migration key in English and Chinese. 4. The notice uses the actual retained byte count after alignment and `Locale.ROOT`. It describes the oversized-single-line case explicitly. 5. The truncated path decodes into the prefixed response builder instead of constructing a full decoded content string and then concatenating it. Responses remain buffered and bounded by the configured file-content limit, with the notice additional to that content. 6. The docs explain UTF-8 decoding, custom logging charset configuration and the cap on active/rotated files, including the shipped 100 MB rolling threshold. Local OpenJDK 11 checks passed: full-reactor `spotless:apply` and `-q -DskipTests verify`, all 25 selected utility/reader/config tests, and the REST integration case covering all four endpoint requests. No test failures or skips. The PR remains one feature commit (19 files); shared engine/connector fixes are still separate in #12454, with no workflow changes here. Please take another look at this update. I am monitoring the new [Build run](https://github.com/SEZ9/seatunnel/actions/runs/36087309979) and will update this comment with its result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
