SEZ9 commented on PR #12299: URL: https://github.com/apache/seatunnel/pull/12299#issuecomment-5771005454
Thanks for the update on head `5564bd74f6ba`. Here is where the earlier findings stand from my side: **Pending verification** - **F3/F4 (truncation marker) and F8 (duplicated MB-to-bytes / `<= 0` sentinel):** the latest review points to the notice in `LogContentReader` (wired into both the v2 servlet and the v1 command processor) and the consolidation into `HttpConfig.getLogResponseMaxSizeBytes()`. I have not checked the diff myself yet, so I am not closing these out on that basis alone. Could you point me to the commit(s) carrying these changes so I can confirm? A short reader-level assertion for the exact-at-limit case (no notice) would be a nice-to-have. **Still open / please confirm** - **F1 (charset):** I don't see anything in the thread about the small-file path (`readFileToStr`, platform default) vs. the over-limit path (UTF-8) in `FileUtils`. Are both paths now decoding with the same charset? If so, please point me to the change. - **F2 / F6 (incompatible-changes.md and rest-api-v1.md en/zh):** the default 64 MB tail now applies to the v1 endpoints as well, so please add a note to incompatible-changes.md and document the option in both rest-api-v1.md pages, not only rest-api-v2.md. - **F5 (extra copy in `tailFromLineStart`):** has the second copy of the retained window been removed? Either a pointer to the fix or a short note on why the extra copy is acceptable is fine. - **F7 (docs):** please replace the hard-coded "last 64 MB" with wording tied to the configured value, and drop the stray double backtick in the zh page above the new note. Separately, the latest review notes the branch now carries four commits unrelated to the log-response change (`7e6afc6194`, `5564bd74f6`, `0e735b4f8f`, `772cc9891c`) while the log code itself is unchanged since `9531cecd4`. I'll hold off on approval until that scope point is settled and the items above are confirmed or addressed. <!-- streview-comment:1231 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
