SEZ9 commented on PR #12299: URL: https://github.com/apache/seatunnel/pull/12299#issuecomment-5738824286
Thanks for the control run ([35166337277](https://github.com/SEZ9/seatunnel/actions/runs/35166337277)) and for tracking the remaining IT failure upstream — that's enough for me to treat it as unrelated to this change. Head is still `9531cecd4`, so there is no new diff for me to re-review and my conclusion from the last round stands: no blockers on the code itself. The one open, non-blocking item is still the truncation-notice check in the log tail path deciding "was this truncated?" from a second, non-atomic size lookup after the tail read already took its own snapshot; deriving it from the single snapshot used for the read would close it, whenever you'd like to. Once the remaining upstream failure is fixed on dev (or this branch rebases past it), a green build is the only remaining item from my side. <!-- streview-comment:1165 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
