SEZ9 commented on PR #12391: URL: https://github.com/apache/seatunnel/pull/12391#issuecomment-5755044336
@SeaSand1024 thanks for the quick turnaround on `0fc63dc5` and for the clear CI breakdown. On the changes themselves: the `Throwable` catch in the `BlockingWorker` fallback close, the same-instance guard around `addSuppressed`, and the extra `SeaTunnelTaskStateTest` cases (middle/last failure position, repeated `close()`, unchecked primary with checked suppressed, `Error`, teardown order, shared instance) cover exactly the gaps I'd want closed here. Nothing further from me on the code, and I agree with @davidzollo's +1. On the Build failures, I agree with your read and with keeping #12391 scoped to the lifecycle-close contract rather than pulling in the #12353 / #12377 cancel-race fix. A couple of concrete asks so we can land this cleanly: 1. Once the re-run finishes, please drop a short note here with the result for `engine-v2-it` and `all-connectors-it-2`. 2. If `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck` fails again on `0fc63dc5`, please paste the assertion/stack snippet from that run so we can confirm it is the same `CANCELED` vs `FAILED` symptom as #12353 and not something new from this PR. If it matches, I'm fine treating it as a known flaky race; we can either wait for #12377 to land and rebase, or merge on the green unit-test matrix plus a clean re-run of the other IT jobs. 3. If `OpengaussCDCIT` is still red after the re-run, please confirm it's the testcontainers startup issue (e.g. image pull / container start failure) rather than a test assertion, since that job is unrelated to the engine code touched here. No need to push anything else unless the re-run surfaces something new. <!-- streview-comment:1212 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
