DanielLeens commented on PR #12391: URL: https://github.com/apache/seatunnel/pull/12391#issuecomment-5805501879
Thanks @SeaSand1024 for the sync and the direct job links. I checked this the same way as last time: `git compare` between the previously-reviewed head (0fc63dc5) and the new one (57890813b) shows 28 commits and 177 changed files, none of which are this PR's own three files (`TaskExecutionService.java`, `SeaTunnelTask.java`, `SeaTunnelTaskStateTest.java`). So this is confirmed a pure dev-sync -- zero overlap with the diff I already reviewed -- and doesn't reopen the code review. On the CI picture: `OpengaussCDCIT.testAddFieldWithRestore` going green on both JDKs in your linked runs matches the expected outcome now that #12346 (merged to dev on 2026-09-20) is picked up by the sync. `engine-v2-it` staying out of scope is still correct -- `SplitClusterFaultToleranceIT` depends on #12311, which hasn't merged yet, so that failure mode is unrelated to this PR's diff and untouched by the sync. My conclusion is unchanged: the code side has been ready since my last review, and the one CI gap that was attributable to something fixable (the Opengauss job) is now closed. This is ready to merge on the green unit-test matrix plus the now-green `all-connectors-it-2`, without waiting on the separately-tracked engine-v2-it flakes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
