SEZ9 commented on PR #12605: URL: https://github.com/apache/seatunnel/pull/12605#issuecomment-5975711998
Thanks @SEPURI-SAI-KRISHNA — the measured table settles Issue 1. You're right that the deciding factor is the string form being parsed as an integer, not whether the value is fractional, so the earlier "a fractional source is rejected" wording would have misled anyone trying `CAST(5.0 AS TINYINT)`. The paragraph you quoted looks correct to me. Two things I can't verify from this thread: please confirm the identical text is on both pages, and whether the earlier "casting to an integral type rejects..." sentence was also reworded. The paragraph you quoted only covers floating-point sources per target, so it doesn't by itself show that the integral-type wording (which overstated things while `BIGINT` still wraps) was removed. Issue 2: agreed, leave it. Asserting on the expression text would pin the `ZetaSQLEngine` wrapper format rather than the behaviour this PR changes, and the expression already surfaces with the error, so nothing further needed there. BIGINT: good. Once the separate issue exists, link it from the incompatible-changes entry and post the number here. Javadoc rationale paragraph: fine to keep. On the `numberToInt` wrapping point: at head `5eb6a8ca9bb` the `BigDecimal` and `BigInteger` branches go through the `BigInteger` bound comparison rather than `longValue()`, so that is resolved as far as I can see. Remaining asks: 1. Confirm the updated CAST paragraph is on both pages, and whether the integral-type sentence was reworded (a quote of the current text is enough). 2. Link the BIGINT issue in the incompatible-changes entry and post the number here. After those two, nothing further from my side. <!-- streview-comment:1496 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
