SEZ9 commented on PR #12152: URL: https://github.com/apache/seatunnel/pull/12152#issuecomment-6051235201
Thanks for the rebase and the detailed breakdown, @CryoThrust. On the review scope: nothing changes from my side. F1 (the guarded `execute()` with the fallback-then-complete ordering) and F2 (the three tests, including the positive delivery assertion) remain resolved on this diff, and `CheckpointCoordinatorTest` 19/19 plus spotless clean on both `0d31cf999` and `de042f22b` is consistent with that. Agreed that the double-rejection last-resort branch stays a non-blocking follow-up tracked alongside #12342 rather than reopening here. On the run for `0d31cf999`: the two `all-connectors-it-7` failures you quoted are the same `PostgresCDCIT.testPostgresCdcSnapshotOnlyAndCommittedOffsetStartupModes:625 ยป ConditionTimeout` signature already filed as #12382, and nothing in them references `CheckpointCoordinator` or this diff, so I'm treating them as unrelated. The cancelled `unit-test (11, windows-latest)` job is indeed neutral. Remaining ask is just the one thing: let the fresh run on `de042f22b` (rebased onto `dev` at `760c33a94`) finish and post the result here. If `all-connectors-it-7` comes back with the same #12382 signature and nothing new touches this branch, I'm ready to approve. If anything different shows up, please paste the failing job/test so we can confirm it's not related to F1/F2. <!-- streview-comment:1591 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
