DanielLeens commented on issue #12752:
URL: https://github.com/apache/seatunnel/issues/12752#issuecomment-6145192900

   Thanks for the concrete catalog measurements. The metadata mismatch is 
credible on current `dev`: `DamengCatalog` selects `DATA_LENGTH` but not 
character length, then `DmdbTypeConverter` uses that value as the logical 
length and expands it again for SeaTunnel's string column length. That explains 
the doubled `NVARCHAR(10)` schema.
   
   Please open a focused metadata PR, but do not hard-code `DATA_LENGTH / 2` as 
a general fallback. Your own evidence shows that `NVARCHAR2` may expose 
`CHAR_LENGTH = 0`, and `LENGTH_IN_CHAR` can change the meaning of the available 
fields. The patch should select the necessary metadata explicitly, define the 
fallback only from verified Dameng semantics, and preserve the existing 
CHAR/VARCHAR/NCHAR behavior. Add catalog tests for NVARCHAR and NVARCHAR2, 
including the reported `CHAR_LENGTH = 0` case, and cover the supported 
`LENGTH_IN_CHAR` modes before claiming the mapping is portable. Please link the 
PR here for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to