DanielLeens commented on PR #12608: URL: https://github.com/apache/seatunnel/pull/12608#issuecomment-6181404860
Quick status update for @CodeWithPravinMaske, since a fact from my earlier notes has changed. - #12597 (do not use a nullable column as the snapshot split column) merged into `dev` today as `42d2aab3f84`. That was the ordering condition we agreed on for Issue 1 of my last review, so it is now satisfied. - GitHub currently reports this branch as conflicting with `dev` (`mergeable_state=dirty`, 53 commits behind head `2ca0489fa9`). Could you please sync with the latest `dev` and resolve the conflicts? Based on the earlier round this is most likely the `incompatible-changes.md` entries again, but that is my guess, please check the actual conflict list. - Once the branch is synced, the new CI run will also replace the stale red `Build` pointer. The `ElasticsearchIT` failures from the previous run were fixed on `dev` by #12711, so they should clear after the sync. My technical conclusion has not changed: no code-side blocker on `2ca0489fa9`. As a read-only reviewer I cannot do the formal approval, so a committer with write access is still needed, and @SEZ9 has asked to be pinged after the sync. I will re-check the new head when it lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
