DanielLeens commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-6338454990
Thanks @Rangsh and @SEZ9. I checked the disputed pointers on `b137173f7`: - `JobHistoryService.java:267-288` documents and takes the IMap key lock around get/merge/one TTL put, with unlock in finally. It is not relying solely on a per-JobMaster monitor. - `JobHistoryServiceFinishedMetricsTest` covers null metrics at 135-138 and TTL-preserving successful puts at 100-105, 121-126 and 155-160. The configured fixture TTL is 1440 minutes. The last test is currently named `storeFinishedPipelineMetricsKeepsDistinctTaggedMeasurements` (142), rather than the older name quoted in the discussion. - `IMapJobGrowthBenchmarkWorkload.verifyGrowthPhase` (164-193) really does document and retain the first-zero-count-only durability sample; `tearDown` still samples at 196-200. I am not treating per-iteration durability checks as already implemented. The last-key sample remains the agreed #12266 follow-up. For the measurement plan, merge or rebase is fine; please use the same resulting dev baseline for B (fixture only) and C (fixture plus JobHistoryService), record both SHAs, and compare raw samples on the same worker. Since the workflow accepts one PR head per dispatch, that is two paired baseline/candidate dispatches, as you clarified. Please settle the current CV comparison before changing the sampling cadence; then measure the requested cadence separately so it does not silently change the fixture being compared. The fixture/cadence decision and benchmark evidence remain open; I have not dispatched or run benchmarks locally. Maintainer dispatch and final approval are still needed. Current status evidence: head `b137173f7b7d1bb0a6889732401bb01a233585bb`, base `dev`, compare `diverged` (ahead 11, behind 342), mergeable state `blocked`. CI references: [current Build check](https://github.com/apache/seatunnel/runs/118203081434), [Run / all-connectors-it-7 (11, ubuntu-latest)](https://github.com/Rangsh/seatunnel/actions/runs/39283876974/job/118165944971), [Run / connector-sensorsdata-it (11, ubuntu-latest)](https://github.com/Rangsh/seatunnel/actions/runs/39283876974/job/118165945394). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
