Rangsh commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-6357024969
@SEZ9 both confirmed on `b137173f7`. No new push. 1. `never().computeIfAbsent` is not in the test class. I searched `JobHistoryServiceFinishedMetricsTest` at this head and there is no `computeIfAbsent` assertion anywhere in it. The observable-contract assertions are the `put` verifications and the captured stored metrics already cited: null at `:135-138`, and the TTL `put`s at `:100-105`, `:121-126`, and `:155-160`. 2. The test at `:155-160` is `storeFinishedPipelineMetricsKeepsDistinctTaggedMeasurements`, declared at `:142`. `storeFinishedPipelineMetricsKeepsExistingMetricsForOtherTags` is not a method in this class. The `:155-160` lines are the `verify(...).put(eq(jobId), metricsCaptor.capture(), eq(1440L), eq(TimeUnit.MINUTES))` inside that test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
