SEZ9 commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-6355670893
@Rangsh thanks for restating — that covers the null-metrics and TTL parts of F6. - **Null metrics:** `storeFinishedPipelineMetricsRejectsNullMetrics` (`:135-138`) expecting `NullPointerException` on `storeFinishedPipelineMetrics(1L, null)` addresses the null path. - **TTL-preserving `put`:** the three success paths verifying `put(eq(1L), any(), eq(1440L), eq(TimeUnit.MINUTES))`, with `FINISHED_JOB_EXPIRE_MINUTES` at `1440L` (`:57`), address the TTL contract. Two things before I close F6: 1. **`never().computeIfAbsent`:** you note that none of the cited tests use `computeIfAbsent`, but F6 was about the test class asserting on its absence. Since there is no new push, could you point me to where that assertion lives on `b137173f7`, or confirm it is not in the class? If it is still there, I'd still prefer it be replaced with an assertion on the observable contract. 2. **Test name:** the thread shows two names for the third test — `storeFinishedPipelineMetricsKeepsExistingMetricsForOtherTags` and `storeFinishedPipelineMetricsKeepsDistinctTaggedMeasurements`. Could you confirm which one is at `:155-160`? Once those are confirmed I'll re-check the file and update F6. <!-- streview-comment:1956 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
