DanielLeens commented on PR #12974: URL: https://github.com/apache/seatunnel/pull/12974#issuecomment-6397072929
Thanks for enabling Actions and for the detailed CI report, @SiriusTL666! I checked fork run 40152563142: it is completed/success and bound to the unchanged head ef9d5526, so the CI gate from my review is now met. There is no new commit since my review, so the non-blocking suggestions are unchanged: Issue 2 (read_timeout_ms is a no-op on the sink) and Issue 4 (make the connect-timeout regression test deterministic so it can fail without the fix). Both are optional polish and I would be happy to re-check them if you push a follow-up commit. The remaining gate is an approval from a committer with write access. Nothing was executed locally; this is based on code reading and the fork CI evidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
