SiriusTL666 commented on PR #12974: URL: https://github.com/apache/seatunnel/pull/12974#issuecomment-6434509287
@nzw921rx — flagging this one for you since you have been merging in the connector area today. Please ignore if it is already on your list. **Current state.** `DanielLeens` has approved, and the Apache-side `Build` check on head `fcac22db` is green (completed 2026-10-26 09:33 UTC). My fork run `40204876571` covered the same tree. The branch has been parked since then and is untouched, so nothing needs re-running and no CI work is pending. **What the change does.** It bounds two unbounded network waits in the Socket connector: - `socket.connect(address, 0)` in `SocketSourceReader` and `new Socket(host, port)` in `SocketClient` now use a configurable connect timeout, defaulting to 10s. - A new `read_timeout_ms` option on the **source only**, defaulting to `0`, because `SocketSourceReader` is a long-lived streaming source and a non-zero default would turn every idle period into a failure. An upgrade note was added under `## dev` in both the EN and ZH `incompatible-changes.md`, since the connect default changes from "wait forever" to 10s. **Remaining gate.** Per the `dev` branch rules that is one approval from someone with write access, plus the `Build` check — the check is already satisfied, so only the approval is outstanding. No code changes are being requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
