DanielLeens commented on PR #12974: URL: https://github.com/apache/seatunnel/pull/12974#issuecomment-6406933017
Thank you @SiriusTL666, and congratulations on getting all four review items closed so cleanly. I checked your fork run directly: [Build 40204876571](https://github.com/SiriusTL666/seatunnel/actions/runs/40204876571) is completed with conclusion success on `fcac22dbb93c0c3ec3fe0766d88cf37ccfd27cfa`, which is the current PR head. The four unit-test lanes (Ubuntu and Windows, JDK 11 and 17), the two updated-modules integration jobs, License header, Code style, Dead links and Sanity check all passed; the other integration suites were skipped by the module filter, so I am not counting them as executed. That meets the CI gate from my last review, and I have no remaining source-level blocker. One small observation: when I looked just now, GitHub did not list an Apache-side `Build` check run for this head yet (the earlier head had one that turned green after a short delay). Nothing is needed from you right now; if it still has not appeared after a while, please mention it here and we will find the cheapest way to get it attached, for example re-dispatching the workflow on the branch. The last gate is approval from a committer with write access. Thanks again for the careful work and the clear reports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
