sudeephazra commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6477717300
> @SEZ9 For your comments: > > * CI coverage – Fixed the duplicate-key E2E setup using dedicated source/sink configs with valid HTTPS authorities and literal duplicate keys. Zeta/Spark E2E reruns are pending. > * PR12293-F1 / recommended fixes 1–2: Both keys and values are trimmed in ADLSHadoopConf.java:71. Padded-key/value coverage is in ADLSHadoopConfTest.java:119; blank-key coverage is in ADLSConfigValidatorTest.java:70. English and Chinese docs reflect this behavior. > * F2: Added HNS and same-container rename prerequisites to both sink references. English sink:39. > * F3: Documented naming, authentication mutual exclusion, and blocked-property rules across all four references. English sink:100. Naming-valid template placeholders: config/v2.batch.adls.config.template:39. > * F4: Partially addressed. Authority and tenant validation now runs before endpoint construction in ADLSRuntimeCompatibility.java:133. Custom HTTPS authorities remain accepted for compatibility; there is no host allowlist. Trusted operators must select the credential recipient. This limitation is documented in the references and PR_DESCRIPTION.md:39. > * F5: Aligned the English and Chinese sink tables with factory-exposed options, types, and defaults. English sink:52; Chinese sink:37. > * F6: Documented global account_key log masking and distinguished it from configuration encryption. English sink:138, mirrored in Chinese and both configuration guides. PR-description wording is prepared in PR_DESCRIPTION.md:62. > * F7: Corrected defaults to ONCE / EARLIEST. English source:74 and :76, matching the code and Chinese documentation. > * F8: Expanded the denylist in ADLSConfigValidator.java:99, with provider/class-loading coverage in ADLSConfigValidatorTest.java:117. The option description and docs explicitly describe its non-exhaustive scope and trusted-input requirement. In commit e3d5c7b148399fc61797c28d403c12d189a2a7ab <img width="799" height="629" alt="image" src="https://github.com/user-attachments/assets/5ae8a121-91a6-44aa-bdfd-80b9a79fd01e"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
