DanielLeens commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6514219814
Thanks @SEZ9. I can read the complete author replies through the API; no additional F4-F8 repost is needed for my review. My latest complete review on this same head reconciles F1-F8, including trimmed keys/values, HNS/same-container prerequisites, template/auth rules, trusted custom HTTPS authority, factory parity, masking and defaults. The remaining blocker is the duplicate-key negative integration case at AzuriteWasbFileIT.java:181-199: the starter ConfigBuilder/ConfigShade path normalizes padded keys before the connector validator sees them. Please keep that existing test-boundary issue open and move duplicate-key coverage to an entry that retains both raw keys, while using the engine fixture for a condition that survives configuration normalization. Do not weaken the negative assertion or change unrelated connector behavior to chase the gate. The current Build is still red; no passing current-head acceptance is claimed. This is a reply, not a new full review or another list o f blockers. Snapshot 2026-10-30T03:23:54.162269+00:00: head `e3d5c7b148399fc61797c28d403c12d189a2a7ab`; [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40745881674/job/123330597393) = `SUCCESS`; [Build](https://github.com/apache/seatunnel/runs/123362515679) = `FAILURE`. Base `dev`; comparison `diverged`, ahead 98, behind 8; merge state `blocked`. Behind/diverged alone is recorded metadata and does not add a sync request. This is an unchanged-head discussion/CI clarification, not a new complete source review, an effective approval or a dismissal of historical requested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
