SEZ9 commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6513191401
Thanks @sudeephazra for the detailed breakdown and for pushing e3d5c7b148399fc61797c28d403c12d189a2a7ab. One heads-up: your comment is cut off on my side right after "F4: ... Trusted operators mu", so I only have the status for F1–F4. Could you re-post the remainder (the rest of the F4 note plus anything on F5–F8) in a follow-up comment? Shorter chunks are fine if that helps avoid the truncation. On what did come through, the described changes line up with what each finding asked for: - **PR12293-F1** — trimming both keys and values in `ADLSHadoopConf.java:71`, with the coverage in `ADLSHadoopConfTest.java:119` and `ADLSConfigValidatorTest.java:70`, is the right direction. I'll confirm against the diff. - **PR12293-F2** — HNS and same-container rename prerequisites in both sink references is what was needed; I'll verify the wording in the diff. - **PR12293-F3** — documenting the naming, auth mutual-exclusion and blocked-property rules plus fixing the template placeholders covers the scope. I'll check that the placeholders in `config/v2.batch.adls.config.template:39` actually pass the validator. - **PR12293-F4** — moving authority/tenant validation ahead of endpoint construction in `ADLSRuntimeCompatibility.java:133` should address the plain-HTTP part; I'll confirm in the diff. Accepting arbitrary HTTPS authorities without an allowlist is acceptable to me for compatibility as long as the docs clearly state that `authority_host` is trusted-operator input and that the `client_secret` is POSTed to whichever host is configured. Please confirm that sentence and where it lands in the docs. Remaining asks: 1. Re-post the truncated tail (F4 wording + F5–F8 status). 2. Ping me once the pending Zeta/Spark E2E reruns you mentioned have completed so I can do a full pass on e3d5c7b148399fc61797c28d403c12d189a2a7ab. <!-- streview-comment:2128 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
