SEZ9 commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6568489993
Thanks for the update. Going back over my earlier F1–F8 notes against the latest revision, here is what I still need from you: **F1 (trimmed vs. raw values)** – The `options.put(key.trim(), value.trim())` change for the extra options is the right direction. Please confirm the routing/auth values (account name, container, suffix, credentials) are also taken from the normalized values rather than re-read raw from the config, so whitespace from env-var substitution can no longer pass validation and then fail later. **F2 (HNS requirement)** – The sink doc should state explicitly that the exactly-once / transactional commit guarantee depends on the container having hierarchical namespace enabled, since that is what makes the `tmp_path` → `path` rename atomic. **F3 (undocumented validation rules)** – Please document the account_name/container naming rules, the auth mutual-exclusion rule, and the blocked `hadoop_adls_properties` keys, and make sure the shipped template placeholders pass those rules. **F4 (OAuth token endpoint)** – If the dedicated-configs change touched this, please point me to it; otherwise the endpoint built from `authority_host`/`tenant_id` still needs to be constrained to secure transport and a well-formed host/tenant before `client_secret` is posted. **F5 (option tables)** – Please reconcile the en/zh sink tables and add the options the factories actually expose. **F6 (`account_key` in the default log-mask list)** – This is a global behavior change; please mention it in the PR description and the docs. **F7 (source doc defaults)** – The English source doc should say `discovery_mode` defaults to `ONCE` and `start_mode` to `EARLIEST`, matching the code and the Chinese doc. **F8 (`hadoop_adls_properties` denylist)** – Either tighten the prefix denylist to also cover class-loading and token-provider ABFS keys, or soften the "non-routing, non-credential" wording so the docs match what is actually enforced. If any of these are already addressed, a short per-item note on where to look would help me close them out quickly. <!-- streview-comment:2222 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
