hhcs9527 commented on code in PR #1020:
URL: https://github.com/apache/submarine/pull/1020#discussion_r1045165875
##########
submarine-server/server-core/src/main/java/org/apache/submarine/server/s3/Client.java:
##########
@@ -43,19 +45,38 @@
public class Client {
public MinioClient minioClient;
+ public static Map<String,MinioClient> minioClientFactory = new
HashMap<String, MinioClient>();
+ public static Map<String,Client> clientFactory = new HashMap<String,
Client>();
+
+ public static Client getClient(String endpoint) {
Review Comment:
Hi @cdmikechen , I agree with you.
But the enum type is more suitable for the predefined class (no argument to
init). In our case, we need to init different users in testing, which cannot be
predefined; that's why I use double-check locking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
