cdmikechen commented on code in PR #1020:
URL: https://github.com/apache/submarine/pull/1020#discussion_r1055923503
##########
submarine-server/server-core/src/main/java/org/apache/submarine/server/s3/Client.java:
##########
@@ -45,30 +47,57 @@
/**
* S3(Minio) default client
*/
-public class Client {
+public enum Client {
+
DEFAULT(SubmarineConfiguration.getInstance().getString(SubmarineConfVars.ConfVars.SUBMARINE_S3_ENDPOINT)),
Review Comment:
When using an enum as a factory to get a single instance object, using a
limited number of enum definitions does not achieve the final effect of a
dynamic factory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
