[GitHub] [submarine] hhcs9527 commented on a diff in pull request #1020: SUBMARINE-1349. Fix the syntax error reported in sonarcloud and add init value for apiversion in XGboostjobList.java

Wed, 21 Dec 2022 05:36:57 -0800 


hhcs9527 commented on code in PR #1020:
URL: https://github.com/apache/submarine/pull/1020#discussion_r1054397344


##########
submarine-server/server-core/src/main/java/org/apache/submarine/server/manager/ModelVersionManager.java:
##########
@@ -50,16 +50,14 @@ public class ModelVersionManager {
    *
    * @return object
    */
+  private static class ModelVersionManagerHolder {
+    private static ModelVersionManager manager = new 
ModelVersionManager(ModelVersionService.getInstance(),
+                                                                        new 
ModelVersionTagService(),

Review Comment:
   Hi @cdmikechen ,
   Not sure what you mean by adding some test cases for the minio client 
section here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to