cdmikechen commented on code in PR #1020:
URL: https://github.com/apache/submarine/pull/1020#discussion_r1055918763
##########
submarine-server/server-core/src/main/java/org/apache/submarine/server/manager/ModelVersionManager.java:
##########
@@ -50,16 +50,14 @@ public class ModelVersionManager {
*
* @return object
*/
+ private static class ModelVersionManagerHolder {
+ private static ModelVersionManager manager = new
ModelVersionManager(ModelVersionService.getInstance(),
+ new
ModelVersionTagService(),
Review Comment:
New code changes need to be supported by test cases, otherwise they will
reduce code coverage and fail to prove code robustness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
