paul-lartigau opened a new pull request, #3715: URL: https://github.com/apache/tinkerpop/pull/3715
https://issues.apache.org/jira/browse/TINKERPOP-3294 captureRemovedProperty() was checking the step's cardinality field, which is null when property() is called without an explicit cardinality. The old value passed to vertexPropertyChanged() was then always empty, even though the property itself was written with the graph's default cardinality. The effective cardinality (explicit one, or the graph default for the key) was already computed in sideEffect() but not used. It is now passed to captureRemovedProperty(). Testing: * Added shouldCaptureOldVertexPropertyWhenChangedWithDefaultCardinality to EventStrategyProcessTest. It is skipped for graphs whose default cardinality for the key is not single. * Ran EventStrategyProcessTest through TinkerGraphProcessStandardTest: passes with the fix, fails without it. Merge notes: the code differs on 3.8-dev, the fallback cardinality is computed after the call to captureRemovedProperty(), so it needs to be moved above it when merging forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
