kenhuuu commented on code in PR #3715:
URL: https://github.com/apache/tinkerpop/pull/3715#discussion_r4273222599
##########
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/EventStrategyProcessTest.java:
##########
@@ -1051,6 +1052,39 @@ public void vertexPropertyChanged(final Vertex element,
final VertexProperty old
assertThat(triggered.get(), is(true));
}
+ @Test
+ @FeatureRequirementSet(FeatureRequirementSet.Package.VERTICES_ONLY)
+ public void
shouldCaptureOldVertexPropertyWhenChangedWithDefaultCardinality() {
+ assumeTrue(graph.features().vertex().getCardinality("to-change") ==
VertexProperty.Cardinality.single);
Review Comment:
This fix also changes behavior when the graph’s default cardinality is set,
but this test only runs for default single cardinality. Please add a second
test for default set and ensure it executes with TinkerGraph by configuring
`TinkerGraphProvider#getBaseConfiguration()` for that test method, following
the existing pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
