paul-lartigau commented on code in PR #3715:
URL: https://github.com/apache/tinkerpop/pull/3715#discussion_r4268438281
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java:
##########
@@ -126,7 +126,7 @@ protected void sideEffect(final Traverser.Admin<S>
traverser) {
// find property to remove. only need to capture the removedProperty
if eventing is configured
final Property removedProperty = eventingIsConfigured ?
- captureRemovedProperty(element, key, value, es) :
+ captureRemovedProperty(element, key, value,
effectiveCardinality, es) :
Review Comment:
You're right, I missed that. I've patched it on my side in a fork for now,
so applying it to 3.8.x only is fine, and I'll pick it up there later. I'll
retarget this PR to 3.8-dev.
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java:
##########
@@ -126,7 +126,7 @@ protected void sideEffect(final Traverser.Admin<S>
traverser) {
// find property to remove. only need to capture the removedProperty
if eventing is configured
final Property removedProperty = eventingIsConfigured ?
- captureRemovedProperty(element, key, value, es) :
+ captureRemovedProperty(element, key, value,
effectiveCardinality, es) :
Review Comment:
You're right, I missed that. I've patched it on my side in a fork for now,
so applying it to 3.8.x only is fine, and I'll pick it up there later. I'll
retarget this PR to 3.8-dev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
