kenhuuu commented on code in PR #3715:
URL: https://github.com/apache/tinkerpop/pull/3715#discussion_r4266501359
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java:
##########
@@ -126,7 +126,7 @@ protected void sideEffect(final Traverser.Admin<S>
traverser) {
// find property to remove. only need to capture the removedProperty
if eventing is configured
final Property removedProperty = eventingIsConfigured ?
- captureRemovedProperty(element, key, value, es) :
+ captureRemovedProperty(element, key, value,
effectiveCardinality, es) :
Review Comment:
On 3.7, this cardinality is used only for event capture. The actual write
below still calls `vertex.property(key, value)` when cardinality is omitted,
and providers may implement that differently from getCardinality(key), which is
documented as potentially only a hint. This could cause the event to report a
replacement when the provider actually appended, or miss a replacement when it
wrote as single. I fully agree with your fix on 3.8-dev though.
Do you need this fix on 3.7.x or can we just apply it to 3.8.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
