FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r441598809
##########
File path: python/tvm/runtime/module.py
##########
@@ -41,6 +41,10 @@ def __init__(self, handle):
self.handle = handle
self._entry = None
self.entry_name = "__tvm_main__"
+ # TODO:(FrozenGene): support rpc
+ if self.type_key == 'GraphRuntimeFactory':
+ #from tvm.runtime.graph_runtime_factory import
GraphRuntimeFactoryModule
+ self._entry = self.runtime_create
Review comment:
@tqchen do you have any suggestion here? For `rpc`, I could think of one
way is to use `ModuleGetTypeKey` to extract and check it is
`GraphRuntimeFactory`. Then we go here. However, I think the way I do is a
little hack (include the logic of `GraphRuntimeFactory`. Do you have any better
idea? Thanks in advance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
