tqchen commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r441659609
########## File path: python/tvm/runtime/module.py ########## @@ -41,6 +41,10 @@ def __init__(self, handle): self.handle = handle self._entry = None self.entry_name = "__tvm_main__" + # TODO:(FrozenGene): support rpc + if self.type_key == 'GraphRuntimeFactory': + #from tvm.runtime.graph_runtime_factory import GraphRuntimeFactoryModule + self._entry = self.runtime_create Review comment: Perhaps we can just support the default function in the GraphRuntimeFactory? so we don't have to change Module ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org