tqchen commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r442344555



##########
File path: python/tvm/runtime/module.py
##########
@@ -41,6 +41,10 @@ def __init__(self, handle):
         self.handle = handle
         self._entry = None
         self.entry_name = "__tvm_main__"
+        # TODO:(FrozenGene): support rpc
+        if self.type_key == 'GraphRuntimeFactory':
+            #from tvm.runtime.graph_runtime_factory import 
GraphRuntimeFactoryModule
+            self._entry = self.runtime_create

Review comment:
       Oh, what i mean is that user can directly use `mod["default"](ctx)` to 
create the model, of course `mod["resnet18"](ctx)` still works




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to