FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r442534625
##########
File path: python/tvm/runtime/module.py
##########
@@ -41,6 +41,10 @@ def __init__(self, handle):
self.handle = handle
self._entry = None
self.entry_name = "__tvm_main__"
+ # TODO:(FrozenGene): support rpc
+ if self.type_key == 'GraphRuntimeFactory':
+ #from tvm.runtime.graph_runtime_factory import
GraphRuntimeFactoryModule
+ self._entry = self.runtime_create
Review comment:
Yes. This is easy to be done when we use `relay.build`. However, when we
complete `export_library` and use `tvm.runtime.load_module` /
`remote.load_module` (remote is rpc) , it is not easy. Because when we load it,
its type is `module`. So, my previous reply means maybe we could use automatic
type wrapper mentioned in original rfc , check the type key when we
`load_module` and go to `GraphRuntimeFactoryModule` directly, then we don’t
modify `module`. How about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
