junrushao1994 commented on a change in pull request #6347:
URL: https://github.com/apache/incubator-tvm/pull/6347#discussion_r479468055
##########
File path: src/target/llvm/llvm_common.cc
##########
@@ -140,16 +132,43 @@ std::unique_ptr<llvm::TargetMachine>
GetLLVMTargetMachine(const std::string& tar
}
std::string err;
- const llvm::Target* target =
llvm::TargetRegistry::lookupTarget(target_triple, err);
- if (target == nullptr) {
+ const llvm::Target* llvm_target =
llvm::TargetRegistry::lookupTarget(target_triple, err);
+ if (llvm_target == nullptr) {
CHECK(allow_null) << err << " target_triple=" << target_triple;
return nullptr;
}
llvm::TargetMachine* tm =
- target->createTargetMachine(target_triple, mcpu, mattr, opt,
llvm::Reloc::PIC_);
+ llvm_target->createTargetMachine(target_triple, mcpu, mattr, opt,
llvm::Reloc::PIC_);
return std::unique_ptr<llvm::TargetMachine>(tm);
}
+std::string LLVMTargetToString(const Target& target) {
+ std::ostringstream os;
+ os << "llvm";
+ if (Optional<String> mtriple = target->GetAttr<String>("mtriple")) {
+ os << " -mtriple=" << mtriple.value();
+ }
+ if (Optional<String> mcpu = target->GetAttr<String>("mcpu")) {
+ os << " -mcpu=" << mcpu.value();
+ }
+ if (Optional<Array<String>> mattr = target->GetAttr<Array<String>>("mattr"))
{
+ bool is_first;
+ os << " -mattr=";
+ for (const String& attr : mattr.value()) {
+ if (is_first) {
+ is_first = false;
+ } else {
+ os << ",";
+ }
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
