junrushao1994 commented on a change in pull request #6347:
URL: https://github.com/apache/incubator-tvm/pull/6347#discussion_r479479672
##########
File path: src/target/llvm/codegen_amdgpu.cc
##########
@@ -228,23 +233,50 @@ inline int DetectROCMApiVersion() {
return 305;
}
-runtime::Module BuildAMDGPU(IRModule mod, std::string target) {
+static void UpdateTargetConfig(const String& key, const String& value,
Review comment:
`ProcessTarget` sounds a little bit vague, because it doesn't mention in
which way we process it...
We are dealing with a dictionary `Map<String, Object>`, which I call "target
config", because it is a configuration used to generate a target, not the
target class itself. This method aims to update one of its key-value entry. So
what about `UpdateTargetConfigKeyValueEntry`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
