junrushao1994 commented on a change in pull request #6347:
URL: https://github.com/apache/incubator-tvm/pull/6347#discussion_r479468506
##########
File path: src/target/llvm/codegen_nvptx.cc
##########
@@ -254,14 +254,35 @@ inline int DetectCUDAComputeVersion() {
}
}
-runtime::Module BuildNVPTX(IRModule mod, std::string target) {
+static void UpdateTargetConfig(const String& key, const String& value,
+ Map<String, ObjectRef>* target_config, bool
error_if_inconsistent) {
+ if (target_config->count(key)) {
+ const ObjectRef& obj = (*target_config)[key];
+ CHECK(obj->IsInstance<StringObj>())
+ << "TypeError: In code generation for AMDGPU, expect key \"" << key
Review comment:
Oooops
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
