comaniac commented on a change in pull request #6347:
URL: https://github.com/apache/incubator-tvm/pull/6347#discussion_r479476578
##########
File path: src/target/llvm/codegen_amdgpu.cc
##########
@@ -228,23 +233,50 @@ inline int DetectROCMApiVersion() {
return 305;
}
-runtime::Module BuildAMDGPU(IRModule mod, std::string target) {
+static void UpdateTargetConfig(const String& key, const String& value,
Review comment:
Hmmm...the reason I feel `UpdateTarget` is weird is that it's not clear
about what is being updated since we didn't pass new values as argument. For
exmple, `dict.update(key, new_value)`. Maybe `ProcessTarget` is better? People
will at least know that we are doing something internally with this target.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
