areusch commented on a change in pull request #7785:
URL: https://github.com/apache/tvm/pull/7785#discussion_r621367983
##########
File path: src/target/source/source_module.cc
##########
@@ -191,17 +192,36 @@ class CSourceCrtMetadataModuleNode : public
runtime::ModuleNode {
<< "}\n";
}
+ void GenerateAOTDescriptor() {
+ code_ << "#include
\"tvm/runtime/crt/internal/aot_executor/aot_executor.h\"\n";
Review comment:
ah, right--we wanted to defer making a public API to a follow-on PR.
that's still true, so perhaps we should keep this here for this PR. my thinking
was that depending on a header file in `tvm/runtime/crt/internal` makes this
code internal. however, when compiling µTVM project, the model operator is
compiled separately from CRT, so the current compilation flow treats operator
code as external right now.
with that said, let's ignore this for now--as you said, we're keeping the
AOT executor interface internal now, and we don't enforce this
internal-external split e.g. by creating a separate include dir at build time
now anyhow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
