giuseros commented on a change in pull request #7785:
URL: https://github.com/apache/tvm/pull/7785#discussion_r620586188
##########
File path: python/tvm/relay/build_module.py
##########
@@ -213,7 +218,7 @@ def _build_module_no_factory(mod, target=None,
target_host=None, params=None, mo
return build(mod, target, params=params, mod_name=mod_name).module
-def build(ir_mod, target=None, target_host=None, params=None,
mod_name="default"):
+def build(ir_mod, target=None, target_host=None, params=None,
mod_name="default", executor="graph"):
Review comment:
In general, I am happy with an object being passed here, but I think
that this deserves an RFC on its own. For the time being I would not overload
the target further, and use this as a good excuse to write an "option object
RFC"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
