[GitHub] [tvm] giuseros commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

[GitBox]

giuseros commented on a change in pull request #7785:
URL: https://github.com/apache/tvm/pull/7785#discussion_r620584765



##########
File path: src/target/source/source_module.cc
##########
@@ -191,17 +192,36 @@ class CSourceCrtMetadataModuleNode : public 
runtime::ModuleNode {
           << "}\n";
   }
 
+  void GenerateAOTDescriptor() {
+    code_ << "#include 
\"tvm/runtime/crt/internal/aot_executor/aot_executor.h\"\n";

Review comment:
       I am not entirely sure I follow :) . `tvm_model_t` is part of the 
internal interface to use AOT, and we agreed to move the executor interface to 
be internal for now. Also, why this would make the operator code internal? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org