kparzysz-quic commented on code in PR #14981:
URL: https://github.com/apache/tvm/pull/14981#discussion_r1213068645
##########
src/target/target_kind.cc:
##########
@@ -257,6 +257,12 @@ TargetJSON TestTargetParser(TargetJSON target) {
/********** Register Target kinds and attributes **********/
+#if defined(__arm__) || defined(__aarch64__)
+#define NATIVE_CPU "arm_cpu"
+#else
+#define NATIVE_CPU "cpu"
+#endif
Review Comment:
This isn't really much of an improvement over being "x86-specific": now the
code is "x86 and ARM-specific". Isn't it possible to set keys using target
parser? It would be nice to have a more general solution for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
