FranklandJack commented on code in PR #14981:
URL: https://github.com/apache/tvm/pull/14981#discussion_r1214174551
##########
python/tvm/relay/op/strategy/arm_cpu.py:
##########
@@ -284,8 +288,21 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type,
target):
name="depthwise_conv2d_nchw.x86",
)
elif layout == "NHWC":
- assert kernel_layout == "HWOI"
- if target.features.has_asimd:
+ # TODO(@FranklandJack)
+ # Handle HWOI in arm_cpu scheudles/compute definition.
+ if kernel_layout == "HWOI":
+ logger.warning(
+ """depthwise_conv2d with layout NHWC and HWOI
+ kernel layout is not optimized for arm_cpu
target.
+ """
+ )
+ strategy.add_implementation(
+ wrap_compute_conv2d(topi.nn.depthwise_conv2d_nhwc,
need_kernel_layout=True),
+
wrap_topi_schedule(conv2d_generic.schedule_depthwise_conv2d_nhwc),
+ name="depthwise_conv2d_nhwc.generic",
+ )
+
+ elif target.features.has_asimd:
Review Comment:
Ah, so I think this might be a bug. The condition I think should be `if
kernel_layout != "HWOI"` so that we fallback on the generic condition in the
unsupported case, does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
