lhutton1 commented on code in PR #14981:
URL: https://github.com/apache/tvm/pull/14981#discussion_r1230639408
##########
python/tvm/topi/arm_cpu/injective.py:
##########
@@ -69,8 +69,10 @@ def schedule_injective(outs):
if list(s[x].op.axis):
# do not vectorize for broadcast
dtype = "uint16" if x.dtype == "bfloat16" else x.dtype
- (io, ii) = s[x].split(list(s[x].op.axis)[-1], 16 //
np.dtype(dtype).itemsize)
- s[x].vectorize(ii)
+ # do not vectorize for custom data types
+ if 0 == dtype.count("custom"):
Review Comment:
nit: this could just be `if dtype.count("custom")`
##########
python/tvm/relay/op/strategy/arm_cpu.py:
##########
@@ -304,8 +321,11 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type,
target):
and kernel.shape[3] == 1 # channel_multiplier == 1
and out_type.dtype == "int32"
and (
- (data.shape[3] % 4 == 0 and data.dtype == "int8" and
target.features.has_dsp)
- or (data.shape[3] % 2 == 0 and data.dtype == "int16")
+ (
+ (data.shape[3] % 4 == 0 and data.dtype == "int8")
+ or (data.shape[3] % 2 == 0 and data.dtype == "int16")
+ )
+ and target.features.has_dsp
Review Comment:
The logic seems to have changed here, was this intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
