FranklandJack commented on code in PR #14981:
URL: https://github.com/apache/tvm/pull/14981#discussion_r1234939668
##########
python/tvm/relay/op/strategy/arm_cpu.py:
##########
@@ -304,8 +321,11 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type,
target):
and kernel.shape[3] == 1 # channel_multiplier == 1
and out_type.dtype == "int32"
and (
- (data.shape[3] % 4 == 0 and data.dtype == "int8" and
target.features.has_dsp)
- or (data.shape[3] % 2 == 0 and data.dtype == "int16")
+ (
+ (data.shape[3] % 4 == 0 and data.dtype == "int8")
+ or (data.shape[3] % 2 == 0 and data.dtype == "int16")
+ )
+ and target.features.has_dsp
Review Comment:
I think so, I think the idea was that we can use the dsp schedules on int8
and int16 only where it is supported, previously it would have used the dsp
schedule for int16 regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
