+1 if the current review process is kept.
Pros:
* Using PRs is good for increasing developers because PRs are very
familiar for many developers.
* Better UI. (no need to copy the diff manually for reviewing patches!)
Cons:
* Discussions can be split. However, according to the below blog post,
any comments and other things on PRs can be recorded on the project's
mailing list or mirrored to the JIRA ticket, so we can search discussion
by searching MLs or JIRAs. Therefore, IMO, it's not a big problem.
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
* github.com is out of Apache infra, so the service can be stopped for
some reason (such as, acquired by some company or system down). I'm
thinking we need to keep the current review process if we have switched
to use GitHub PRs.
Regards,
Akira
On 10/30/15 16:38, Alexander Pivovarov wrote:
Andrew, look at Spark github. They use PRs and I do not see extra merge
commits. Committer can do fast-farward merge using git command line.
PRs are used to leave inline feedbacks for the fix
On Oct 29, 2015 1:34 PM, "Andrew Wang" <andrew.w...@cloudera.com> wrote:
Has anything changed regarding the github integration since the last time
we discussed this? That blog post is from 2014, and we discussed
alternative review systems earlier in 2015.
Colin specifically was concerned about forking the discussion between JIRA
and other places:
http://search-hadoop.com/m/uOzYtkYxo4qazi&subj=Re+Patch+review+process
http://search-hadoop.com/m/uOzYtSz7z624qazi&subj=Re+Patch+review+process
There are also questions about PRs leading to messy commit history with the
extra merge commits. Spark IIRC has something to linearize it again, which
seems important if we actually want to do this.
Could someone outline the upsides of using github? I don't find the review
UI particularly great compared to Gerrit or even RB, and there's the merge
commit issue. For instance, do we think using Github would lead to more
contributions? Improved developer workflows? Have we re-examined
alternatives like Gerrit or RB as well?
On Thu, Oct 29, 2015 at 12:25 PM, Arpit Agarwal <aagar...@hortonworks.com>
wrote:
+1, thanks for proposing it.
On 10/29/15, 10:47 AM, "Owen O'Malley" <omal...@apache.org> wrote:
All,
For code & patch review, many of the newer projects are using the
Github
pull request integration. You can read about it here:
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
It basically lets you:
* have mirroring between comments on pull requests and jira
* lets you close pull requests
* have mirroring between pull request comments and the Apache mail lists
Thoughts?
.. Owen
