bilaharith commented on a change in pull request #1790: changes for combined 
append+flush calls for blockblob(traditionan) an…
URL: https://github.com/apache/hadoop/pull/1790#discussion_r363225156
 
 

 ##########
 File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
 ##########
 @@ -164,6 +169,23 @@ public AzureBlobFileSystemStore(URI uri, boolean 
isSecureScheme, Configuration c
     boolean useHttps = (usingOauth || abfsConfiguration.isHttpsAlwaysUsed()) ? 
true : isSecureScheme;
     initializeClient(uri, fileSystemName, accountName, useHttps);
     this.identityTransformer = new 
IdentityTransformer(abfsConfiguration.getRawConfiguration());
+
+    // Extract the directories that should contain page blobs
 
 Review comment:
   Shall we have these operations as a separate private method and call that 
from this constructor. This constructor is becoming too long.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to