ishaniahuja commented on a change in pull request #1790: changes for combined
append+flush calls for blockblob(traditionan) an…
URL: https://github.com/apache/hadoop/pull/1790#discussion_r365103591
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -309,15 +316,23 @@ private synchronized void
flushWrittenBytesToService(boolean isClose) throws IOE
throw new FileNotFoundException(ex.getMessage());
}
}
-
if (ex.getCause() instanceof AzureBlobFileSystemException) {
ex = (AzureBlobFileSystemException) ex.getCause();
}
lastError = new IOException(ex);
throw lastError;
}
}
- flushWrittenBytesToServiceInternal(position, false, isClose);
+ shrinkWriteOperationQueue();
Review comment:
as discussed offline, please look at new REST API. the code is same for both
the appendBlob and BlockBlob. THe difference at the OutputStream Code is to use
a single upload thread for appendBlob and multiple upload threads for block
Blob. Its a lot of code rewrite, hence the full file read might be more useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
