ishaniahuja commented on a change in pull request #1790: changes for combined
append+flush calls for blockblob(traditionan) an…
URL: https://github.com/apache/hadoop/pull/1790#discussion_r365104492
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -257,17 +265,16 @@ public synchronized void close() throws IOException {
private synchronized void flushInternal(boolean isClose) throws IOException {
maybeThrowLastError();
- writeCurrentBufferToService();
- flushWrittenBytesToService(isClose);
+ writeAndFlushWrittenBytesToService(isClose);
}
private synchronized void flushInternalAsync() throws IOException {
maybeThrowLastError();
- writeCurrentBufferToService();
+ writeCurrentBufferToService(true, false);
flushWrittenBytesToServiceAsync();
}
- private synchronized void writeCurrentBufferToService() throws IOException {
+ private synchronized void writeCurrentBufferToService(final boolean flush,
final boolean isClose) throws IOException {
Review comment:
it does not call flush. but passes flush and close flag in the append method
in AbfsClient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
